murat/pg2ch

Fork 0

Upgrade to modules, pgx/v4 & accoutrements - WIP #36

Open

mattTruebill wants to merge 1 commit from mattTruebill/matt/upgrade-to-modules-and-pgx/v4 into master

mattTruebill commented

2021-02-02 15:19:35 +00:00

(Migrated from github.com)

Upgrade to using go modules.

Upgrade to pgx/4.

Upgrade to using go modules. Upgrade to pgx/4.

👍 1

mattTruebill (Migrated from github.com) reviewed

2021-02-02 15:20:57 +00:00

pkg/config/config.go

pgx/v4 favors taking pg connection as input via a connection string in either url or dsn format.

`pgx/v4` favors taking pg connection as input via a connection string in either url or dsn format.

mattTruebill (Migrated from github.com) reviewed

2021-02-02 15:21:38 +00:00

pkg/consumer/consumer.go

Lots of changes like this where will now be referencing repos that were spun-out of the main pgx repo as of version 4.

Lots of changes like this where will now be referencing repos that were spun-out of the main `pgx` repo as of version 4.

mattTruebill (Migrated from github.com) reviewed

2021-02-02 15:22:58 +00:00

pkg/consumer/consumer.go

This is copypasta from an example in pglogrepl and could use careful review.

This is copypasta from an example in `pglogrepl` and could use careful review.

mattTruebill (Migrated from github.com) reviewed

2021-02-02 15:23:58 +00:00

pkg/replicator/replicator.go

Lots of changes like this (tx => *tx) now that go doesn't automatically dereference pointers to interfaces.

Lots of changes like this (`tx` => `*tx`) now that go doesn't automatically dereference pointers to interfaces.

EugeneKovalev commented

2021-04-18 12:39:42 +00:00

(Migrated from github.com)

@mkabilov @mattTruebill any news on this?

I am not able to install pg2ch. Right now I am getting this:

go get -u github.com/mkabilov/pg2ch

# github.com/mkabilov/pg2ch/pkg/utils/kvstorage
go/pkg/mod/github.com/mkabilov/pg2ch@v1.0.0/pkg/utils/kvstorage/diskv.go:52:41: s.storage.ReadString undefined (type *diskv.Diskv has no field or method ReadString)
go/pkg/mod/github.com/mkabilov/pg2ch@v1.0.0/pkg/utils/kvstorage/diskv.go:60:18: s.storage.WriteString undefined (type *diskv.Diskv has no field or method WriteString)

@mkabilov @mattTruebill any news on this? I am not able to install pg2ch. Right now I am getting this: **go get -u github.com/mkabilov/pg2ch** ``` # github.com/mkabilov/pg2ch/pkg/utils/kvstorage go/pkg/mod/github.com/mkabilov/pg2ch@v1.0.0/pkg/utils/kvstorage/diskv.go:52:41: s.storage.ReadString undefined (type *diskv.Diskv has no field or method ReadString) go/pkg/mod/github.com/mkabilov/pg2ch@v1.0.0/pkg/utils/kvstorage/diskv.go:60:18: s.storage.WriteString undefined (type *diskv.Diskv has no field or method WriteString) ```

buildscientist commented

2021-05-22 02:09:35 +00:00

(Migrated from github.com)

Hello @mkabilov and @mattTruebill - thanks for your hard work on this project.

Do either of you have an ETA when this PR will be pulled in? I have an outstanding issue where pg2ch will not handle DateTime64 CH fields due to the underlying ch-go library not supporting them. This has been fixed in the current version of clickhouse-go which is being pulled in via gomod dependency management.

Hello @mkabilov and @mattTruebill - thanks for your hard work on this project. Do either of you have an ETA when this PR will be pulled in? I have an outstanding issue where pg2ch will not handle DateTime64 CH fields due to the underlying ch-go library not supporting them. This has been fixed in the current version of clickhouse-go which is being pulled in via gomod dependency management.

buildscientist commented

2021-05-22 02:10:38 +00:00

(Migrated from github.com)

@EugeneKovalev

You can clone the repository and build locally. Until this PR Is merged go get will not work.

@EugeneKovalev You can clone the repository and build locally. Until this PR Is merged `go get` will not work.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin mattTruebill/matt/upgrade-to-modules-and-pgx/v4:mattTruebill/matt/upgrade-to-modules-and-pgx/v4

git switch mattTruebill/matt/upgrade-to-modules-and-pgx/v4

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master

git merge --no-ff mattTruebill/matt/upgrade-to-modules-and-pgx/v4

git switch mattTruebill/matt/upgrade-to-modules-and-pgx/v4

git rebase master

git switch master

git merge --ff-only mattTruebill/matt/upgrade-to-modules-and-pgx/v4

git switch mattTruebill/matt/upgrade-to-modules-and-pgx/v4

git rebase master

git switch master

git merge --no-ff mattTruebill/matt/upgrade-to-modules-and-pgx/v4

git switch master

git merge --squash mattTruebill/matt/upgrade-to-modules-and-pgx/v4